Connect outline nodes to episodes #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electronicbites
force-pushed
the
connect-outline-nodes-to-episodes
branch
4 times, most recently
from
f1ed47d
to
0259a74
Compare
currently it is optional but it should be required
electronicbites
force-pushed
the
connect-outline-nodes-to-episodes
branch
from
0259a74
to
0aea2f2
Compare
electronicbites
force-pushed
the
connect-outline-nodes-to-episodes
branch
from
0aea2f2
to
72a2696
Compare
electronicbites
force-pushed
the
connect-outline-nodes-to-episodes
branch
from
be065d9
to
c678a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect nodes to episodes. This is a required argument. No node should be be dangling since they would never be shown.
The controller expects a show_id for a node to be created. In order to connect the node the a episode we need do find a episode. In the near future this will be the one in draft mode, or even the one stored in a user preference.
Currently it just returns the episode with the highest number. And episodes have a number now.